Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 QSPI: Use defines for setting address size #11759

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@LMESTM
Copy link
Contributor

LMESTM commented Oct 28, 2019

Description (required)

A small clean-up Pull Request, to align with rest of the code following recent changes in QSPI.

Summary of change (What the change is for and why)

The change follows recent updates and can be considered a cosmetic change but should be future proof for any new STM32 devices with QSPI.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

Tested fine on DISCO_L475VG_IOT01A

+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
| target                      | platform_name       | test suite          | result | elapsed_time (sec) | copy_method |
+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | tests-mbed_hal-qspi | OK     | 37.78              | default     |
+-----------------------------+---------------------+---------------------+--------+--------------------+-------------+
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
| target                      | platform_name       | test suite                                              | result | elapsed_time (sec) | copy_method |
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
| DISCO_L475VG_IOT01A-GCC_ARM | DISCO_L475VG_IOT01A | features-storage-tests-blockdevice-general_block_device | OK     | 38.42              | default     |
+-----------------------------+---------------------+---------------------------------------------------------+--------+--------------------+-------------+
[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@jeromecoutant

Copy link
Contributor

jeromecoutant left a comment

ST CI OK also with DISCO_F769NI and DISCO_F746NG (other embedded QSPI memories)

@0xc0170 0xc0170 added the needs: CI label Oct 30, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 30, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 30, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 31, 2019
@0xc0170 0xc0170 merged commit 73b4f71 into ARMmbed:master Oct 31, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8707 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.