Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display full path of generated coverage output from unittests. #11763

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@SeppoTakalo
Copy link
Contributor

SeppoTakalo commented Oct 29, 2019

Description (required)

When running unittests with --coverage option, it only tells you that code coverage report created. but without specifying where it went.

This small change makes it verbose to show where the coverage output was generated. Easier for end user to find it.

Summary of change (What the change is for and why)

Display full path of generated coverage output from unittests.

Pull request type (required)

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR
$ mbed test --unittest --coverage both

...

100% tests passed, 0 tests failed out of 47

Total Test time (real) =   0.51 sec




HTML code coverage report created in /Users/seppo/src/mbed-os/BUILD/unittests/coverage/index.html


XML code coverage report created in /Users/seppo/src/mbed-os/BUILD/unittests/coverage.xml

Reviewers (optional)

@ARMmbed/mbed-os-test

@ciarmcom ciarmcom requested a review from ARMmbed/mbed-os-maintainers Oct 29, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Oct 29, 2019

@SeppoTakalo, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@SeppoTakalo SeppoTakalo requested review from lorjala, OPpuolitaival and ARMmbed/mbed-os-test and removed request for OPpuolitaival and lorjala Oct 31, 2019
@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Oct 31, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

Copy link
Contributor

OPpuolitaival left a comment

Looks good!

@SeppoTakalo

This comment has been minimized.

Copy link
Contributor Author

SeppoTakalo commented Oct 31, 2019

Why "travis-ci/pr" does not finish?

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Oct 31, 2019

Sometimes the hook is not updated, I'll restart it

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 31, 2019
@0xc0170 0xc0170 merged commit bf4d51e into master Oct 31, 2019
17 checks passed
17 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8947 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@SeppoTakalo SeppoTakalo deleted the feature_unittest_output branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.