Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLSSOCKET_HANDSHAKE_INVALID test skip if DNS AAA record not available. #11822

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@tymoteuszblochmobica
Copy link
Contributor

tymoteuszblochmobica commented Nov 6, 2019

Description (required)

TLSSOCKET_HANDSHAKE_INVALID test skip if DNS AAA record not available.

Summary of change (What the change is for and why)

TLS test sevrver " badssl.com"doesn't support DNS AAA records for IPV6.
To avoid test fail if no IPV4 is chosen this test is skipped.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers (optional)

@SeppoTakalo
@AnttiKauppila
@michalpasztamobica


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required
Copy link
Member

0xc0170 left a comment

TLS test sevrver " badssl.com"doesn't support DNS AAA records for IPV6.
To avoid test fail if no IPV4 is chosen this test is skipped.

Shall we add this to the commit message? Please do

@0xc0170 0xc0170 added the needs: work label Nov 6, 2019
TLS test sevrver "badssl.com" doesn't support DNS AAA records for IPV6.
To avoid test fail if no IPV4 is chosen this test is skipped.
@tymoteuszblochmobica tymoteuszblochmobica force-pushed the tymoteuszblochmobica:tls branch from cc4d1d2 to eb3befd Nov 6, 2019
@tymoteuszblochmobica

This comment has been minimized.

Copy link
Contributor Author

tymoteuszblochmobica commented Nov 6, 2019

Updated

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Nov 7, 2019
@0xc0170 0xc0170 self-requested a review Nov 7, 2019
@0xc0170
0xc0170 approved these changes Nov 7, 2019
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 7, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 7, 2019

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 8, 2019

CI restarted

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 8, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 816689d into ARMmbed:master Nov 8, 2019
20 checks passed
20 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8699 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
@0xc0170 0xc0170 removed the ready for merge label Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.