Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mbed-os-example-wifi to build only DISCO_L475VG_IOT01A #11872

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@jussisip
Copy link
Contributor

jussisip commented Nov 15, 2019

Description (required)

Currently mbed-os-example-blinky and mbed-os-example-wifi are built for each and every target in Mbed OS. This will change that only DISCO_L475VG_IOT01A is built for mbed-os-example-wifi. DISCO_L475VG_IOT01A was chosen as its one of the wi-fi supported boards and having integrated wi-fi.

Documentation (Details of any document updates required)

Pull request type (required)

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results (required)

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Build passed with GCC_ARM locally in Mac OS X

Passed Example Compilation:
+----------------------+---------------------+-----------+----------+--------------+
| EXAMPLE NAME | TARGET | TOOLCHAIN | TEST GEN | BUILD RESULT |
+----------------------+---------------------+-----------+----------+--------------+
| mbed-os-example-wifi | DISCO_L475VG_IOT01A | GCC_ARM | TEST_OFF | PASSED |
+----------------------+---------------------+-----------+----------+--------------+


Reviewers (optional)


Release Notes (required for feature/major PRs)

Summary of changes
Impact of changes
Migration actions required
@ciarmcom ciarmcom requested review from ARMmbed/mbed-os-maintainers Nov 15, 2019
@ciarmcom

This comment has been minimized.

Copy link
Member

ciarmcom commented Nov 15, 2019

@jussisip, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

Copy link
Member

0xc0170 left a comment

Please add the reason in the commit message (already in PR itself). otherwise looks fine

Currently mbed-os-example-blinky and mbed-os-example-wifi are built for each and every target in Mbed OS. This will change that only DISCO_L475VG_IOT01A is built for mbed-os-example-wifi. DISCO_L475VG_IOT01A was chosen as its one of the wi-fi supported boards and having integrated wi-fi.
@jussisip jussisip force-pushed the jussisip:update_examples branch from 2407b1b to 1c4a5b9 Nov 18, 2019
@jussisip jussisip requested a review from 0xc0170 Nov 18, 2019
Copy link
Contributor

mark-edgeworth left a comment

Looks ok to me

@0xc0170

This comment has been minimized.

Copy link
Member

0xc0170 commented Nov 19, 2019

CI started

@mbed-ci

This comment has been minimized.

Copy link

mbed-ci commented Nov 19, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge

This comment has been minimized.

Copy link
Contributor

adbridge commented Nov 19, 2019

This is needed for 5.14 branch as wifi building there is broken

@adbridge adbridge added ready for merge and removed needs: CI labels Nov 19, 2019
@adbridge adbridge merged commit 71c6b9a into ARMmbed:master Nov 19, 2019
26 checks passed
26 checks passed
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/dynamic-memory-usage RTOS ROM(-688 bytes) RAM(-16 bytes)
Details
jenkins-ci/exporter Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/mbed2-build-ARM Success
Details
jenkins-ci/mbed2-build-GCC_ARM Success
Details
jenkins-ci/mbed2-build-IAR Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Success!
Details
travis-ci/docs Success!
Details
travis-ci/doxy-spellcheck Success!
Details
travis-ci/events Success! Runtime is 8621 cycles.
Details
travis-ci/gitattributestest Success!
Details
travis-ci/include_check Success!
Details
travis-ci/licence_check Success!
Details
travis-ci/littlefs Success! Code size is 8420B.
Details
travis-ci/psa-autogen Success!
Details
travis-ci/tools-py2.7 Success!
Details
travis-ci/tools-py3.5 Success!
Details
travis-ci/tools-py3.6 Success!
Details
travis-ci/tools-py3.7 Success!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.