-
Notifications
You must be signed in to change notification settings - Fork 3k
LPC55S69_NS default TDBStore size increased to 32kB #11913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Previously it was 2 pages - 1kB - which isn't sufficient to store Reserved Area and Master Record. Reserved are requires one page and Master Record takes two pages. With 512B page size and having two areas, active and inactive, the minimum size requirement becomes 2 areas * 3 pages = 3kB. That isn't enough to store any keys though.
@VeijoPesonen, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x32 increase is a lot, is it the right default value? @jannehekkala @yogpan01 @SeppoTakalo @mmahadevan108 @maclobdell
It's default and once you start to develop your application you will set the size yourself. And you pick the location also yourself. You need to know how much space your application needs from TDBStore. |
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Once in a while we see this failure in I'll restart tests |
There is PR addressing tbd store so that should fix above I believe This is good to go |
Description (required)
Previously the size was 2 pages - 1kB - which isn't sufficient to store Reserved Area and Master Record. Reserved Area requires one page and Master Record takes two pages. With 512B page size and having two areas, active and inactive, the minimum size requirement becomes 2 areas * 3 pages = 3kB. That isn't enough to store any keys though.
Added a sanity check to TDBStore constructor. Only effective when the binary is build with debug profile
Summary of change (What the change is for and why)
Documentation (Details of any document updates required)
Pull request type (required)
Test results (required)
Before
After
Reviewers (optional)
@SeppoTakalo
@teetak01
Release Notes (required for feature/major PRs)
Summary of changes
Impact of changes
Migration actions required