Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up unittests by not limitting Make to spawn more processes #11927

Merged
merged 1 commit into from Dec 2, 2019

Conversation

SeppoTakalo
Copy link
Contributor

Description

Summary of change

Speed up unittests by not limitting Make to spawn more processes.

By default, the Make will use as many processes as specified by -j[N] parameter. But if there is a parameter -l[N] parameter given, it does not spawn any more processes, if load average is over N.

This greatly limits the effect of parallel build. On Mac OS X, I can see load average as high as 40, when building unittests. This is normal, and the system is still responsive.

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@JuhPuur


Release Notes

Summary of changes

Impact of changes

Migration actions required

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@ciarmcom ciarmcom requested review from JuhPuur and a team November 22, 2019 12:00
@ciarmcom
Copy link
Member

@SeppoTakalo, thank you for your changes.
@JuhPuur @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 25, 2019

@JuhPuur @ARMmbed/mbed-os-test Please review

Copy link

@kimlep01 kimlep01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a welcome speed boost

@0xc0170 0xc0170 added needs: CI release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: review labels Dec 2, 2019
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2019

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 2, 2019

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 2, 2019
@0xc0170 0xc0170 merged commit 0edce8a into ARMmbed:master Dec 2, 2019
@SeppoTakalo SeppoTakalo deleted the speed_up_unittests branch December 4, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants