Skip to content

USB device HID test: remove duplicated define #12012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

USB device HID test: remove duplicated define #12012

merged 1 commit into from
Dec 4, 2019

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Dec 3, 2019 •
edited
Loading

Description

Summary of change

Fix #11977

mbed-os/TESTS/usb_device/hid/main.cpp

Lines 45 to 46 in ffdd543

#define MSG_KEY_DEVICE_READY "ready"
#define MSG_KEY_DEVICE_READY "dev_ready"

MSG_KEY_DEVICE_READY is defined twice

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Release Notes

Summary of changes

Impact of changes

Migration actions required

@0xc0170 0xc0170 requested a review from fkjagodzinski December 3, 2019 12:37
fkjagodzinski
fkjagodzinski approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jeromecoutant, LGTM 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2019

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Dec 3, 2019
@mbed-ci
Copy link

mbed-ci commented Dec 3, 2019

Test run: SUCCESS

Summary: 5 of 5 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 removed the needs: CI label Dec 4, 2019
@0xc0170 0xc0170 merged commit 419e58a into ARMmbed:master Dec 4, 2019
@jeromecoutant jeromecoutant deleted the PR_USB_HIDTEST branch December 4, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests-usb_device-hid: MSG_KEY_DEVICE_READY is defined twice
4 participants
@jeromecoutant @0xc0170 @mbed-ci @fkjagodzinski