Skip to content

syntax error corrections - rm unnecessary semicolons #12169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2020
Merged

syntax error corrections - rm unnecessary semicolons #12169

merged 1 commit into from
Jan 2, 2020

Conversation

HeathPetersen
Copy link
Contributor

Summary of changes

Remove semicolons after namespace sections and extern "C" sections because they aren't required and produce warnings / errors when using pedantic compilation.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Unknown

@ciarmcom ciarmcom requested review from a team December 27, 2019 00:00
@ciarmcom
Copy link
Member

@HeathPetersen, thank you for your changes.
@ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 30, 2019

Thanks @HeathPetersen. We will run CI and this should be ready.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 2, 2020
@0xc0170 0xc0170 merged commit 3c7b7c1 into ARMmbed:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HeathPetersen @ciarmcom @0xc0170 @mbed-ci @hugueskamba