Skip to content

Change size embedded in the temp_ram_page_data #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2020
Merged

Change size embedded in the temp_ram_page_data #12173

merged 1 commit into from
Jan 2, 2020

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Dec 29, 2019

Summary of changes

The size stated in the struct header was 0xB0, however
the actual size(including the header) is 0xAC. Changed the
len value in the header, to avoid memory corruption.
Fixes #12171

Impact of changes

Migration actions required

Documentation

none

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Change size embedded in the temp_ram_page_data
dadb621 
The size stated in the struct header was 0xB0, however
the actual size(including the header) is 0xAC. Changed the
len value in the header, to avoid memory corruption.
Raised in ARMmbed#12171
@RonEld RonEld mentioned this pull request Dec 29, 2019
Closed
@ciarmcom ciarmcom requested a review from a team December 29, 2019 16:00
@ciarmcom
Copy link
Member

@RonEld, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 requested a review from a team December 30, 2019 13:05
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Jan 2, 2020
@0xc0170 0xc0170 merged commit 01fdcfd into ARMmbed:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@urutva urutva urutva approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PSA: Bootloader data length error in attestation service
5 participants
@RonEld @ciarmcom @0xc0170 @mbed-ci @urutva