Skip to content

Conversation

kjbracey
Copy link
Contributor

@kjbracey kjbracey commented Jan 7, 2020

Summary of changes

pbuf_free(NULL) causes an LWIP_ASSERT. Make the call conditional.

Fixes #12184

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


`pbuf_free(NULL)` causes an `LWIP_ASSERT`. Make the call conditional.

Fixes ARMmbed#12184
@ciarmcom
Copy link
Member

ciarmcom commented Jan 7, 2020

@kjbracey-arm, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team January 7, 2020 12:00
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 7, 2020

CI started

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 label Jan 7, 2020
@mbed-ci
Copy link

mbed-ci commented Jan 7, 2020

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@0xc0170 0xc0170 removed the needs: CI label Jan 7, 2020
@0xc0170 0xc0170 merged commit c8ac1ef into ARMmbed:master Jan 7, 2020
@kjbracey kjbracey deleted the lwipclose branch April 27, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LWIP::socket_close() can attempt to free a null pbuf structure
6 participants