Skip to content

ST targets: Replace UARTSerial references with BufferedSerial #12208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2020
Merged

ST targets: Replace UARTSerial references with BufferedSerial #12208

merged 1 commit into from
Jan 17, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Jan 8, 2020 •
edited
Loading

Summary of changes

BufferedSerial is UARTSerial renamed to convey the original purpose of
the class. It is the recommended buffered I/O serial class.

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar

@hugueskamba
ST targets: Replace UARTSerial references with BufferedSerial
03cff0a 
BufferedSerial is UARTSerial renamed to convey the original purpose of
the class. It is the recommended buffered I/O serial class.
@MarceloSalazar MarceloSalazar requested a review from a team January 8, 2020 08:52
@jeromecoutant
Copy link
Collaborator

MarceloSalazar requested a review from ARMmbed/team-st-mcd

We can only check the STModCellular file.
Unfortunately, compilation is failing...
[Fatal Error] STModCellular.cpp@159,10: 'drivers/BufferedSerial.h' file not found

@MarceloSalazar
Copy link

@jeromecoutant I guess you need #12207 first

@ciarmcom ciarmcom requested review from MarceloSalazar and a team January 8, 2020 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 8, 2020

@hugueskamba, thank you for your changes.
@MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2020

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 17, 2020
@0xc0170 0xc0170 merged commit d6e69ef into ARMmbed:master Jan 17, 2020
@hugueskamba hugueskamba deleted the hk-replace-uartserial-st branch June 30, 2020 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

+1 more reviewer

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hugueskamba @jeromecoutant @MarceloSalazar @ciarmcom @0xc0170 @mbed-ci @evedon