Skip to content

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Jan 14, 2020

Summary of changes

The psa_setup.c.tpl jinja template would strip whitespace from before
the partition name comment when inserting non-test partition database
entries. Fix the template to generate psa_setup.c with the partition
name comment properly indented.

This will help avoid weird changes to psa_setup.c that cause it to fail AStyle checks when running release.py.

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

@jainvikas8


The psa_setup.c.tpl jinja template would strip whitespace from before
the partition name comment when inserting non-test partition database
entries. Fix the template to generate psa_setup.c with the partition
name comment properly indented.
@jainvikas8
Copy link
Contributor

This actually fixes - #12084

@ciarmcom ciarmcom requested review from jainvikas8 and a team January 14, 2020 18:00
@ciarmcom
Copy link
Member

@Patater, thank you for your changes.
@jainvikas8 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 and removed needs: CI labels Jan 15, 2020
@0xc0170 0xc0170 merged commit 0fd8bb6 into ARMmbed:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants