Add check for __APPLE__ & __MACH__ to fix unit tests on macOS #12315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it's related but I have the Test 53 failing on macOS Catalina: test 53
Start 53: platform-ATCmdParser
53: Test command: /Users/ladislas/dev/github/mbed-os/UNITTESTS/build/platform-ATCmdParser
53: Test timeout computed to be: 1500
53: Running main() from gmock_main.cc
53: [==========] Running 13 tests from 1 test case.
53: [----------] Global test environment set-up.
53: [----------] 13 tests from test_ATCmdParser
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_create
53: [ OK ] test_ATCmdParser.test_ATCmdParser_create (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_set_timeout
53: [ OK ] test_ATCmdParser.test_ATCmdParser_set_timeout (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_process_oob
53: [ OK ] test_ATCmdParser.test_ATCmdParser_process_oob (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_flush
53: [ OK ] test_ATCmdParser.test_ATCmdParser_flush (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_write
53: [ OK ] test_ATCmdParser.test_ATCmdParser_write (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_set_delimiter
53: [ OK ] test_ATCmdParser.test_ATCmdParser_set_delimiter (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_read
53: [ OK ] test_ATCmdParser.test_ATCmdParser_read (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_debug_on
53: [ OK ] test_ATCmdParser.test_ATCmdParser_debug_on (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_abort
53: [ OK ] test_ATCmdParser.test_ATCmdParser_abort (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_printf
53: [ OK ] test_ATCmdParser.test_ATCmdParser_printf (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_send
53: [ OK ] test_ATCmdParser.test_ATCmdParser_send (0 ms)
53: [ RUN ] test_ATCmdParser.test_ATCmdParser_recv
53/54 Test #53: platform-ATCmdParser ......................................Bus error***Exception: 0.15 sec
test 54
Start 54: platform-CircularBuffer
54: Test command: /Users/ladislas/dev/github/mbed-os/UNITTESTS/build/platform-CircularBuffer
54: Test timeout computed to be: 1500
54: Running main() from gmock_main.cc
54: [==========] Running 1 test from 1 test case.
54: [----------] Global test environment set-up.
54: [----------] 1 test from TestCircularBuffer
54: [ RUN ] TestCircularBuffer.constructor
54: [ OK ] TestCircularBuffer.constructor (0 ms)
54: [----------] 1 test from TestCircularBuffer (0 ms total)
54:
54: [----------] Global test environment tear-down
54: [==========] 1 test from 1 test case ran. (1 ms total)
54: [ PASSED ] 1 test.
54/54 Test #54: platform-CircularBuffer ................................... Passed 0.14 sec
98% tests passed, 1 tests failed out of 54
Total Test time (real) = 7.76 sec
The following tests FAILED:
53 - platform-ATCmdParser (Bus error)
Errors while running CTestI've narrowed it down to this line: EXPECT_TRUE(at1.recv("%c %d %x %s\r\n%c %d %x %s\r\n", &c, &intval, &hexval, &text)); |
|
@ladislas, thank you for your changes. |
evedon
reviewed
Jan 27, 2020
This is a bug and it should be fixed in a different PR. It seems that there is a duplication of the response format string that is causing the seg fault. @mtomczykmobica |
|
@ladislas, thank you for your changes. |
evedon
approved these changes
Jan 27, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This PR does not contain release version label after merging. |
|
@ladislas could you raise an issue for the |
|
@maciejbocianski just did! ✅ |
0xc0170
added
release-version: 6.0.0-alpha-2
|
I've fixed the version: Set to 6.0.0-alpha-2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
On macOS Catalina, with a fresh clone of mbed-os, running
mbed test --unittestsresults in the following issue:The same happens with the
cmakeapproach.Adding
#if defined(__unix__) || defined(__APPLE__) || defined(__MACH__)fixes the issue and the tests run correctly.Impact of changes
The change fixes unit testing on macOS Catalina.
Migration actions required
Documentation
n/a
Pull request type
Test results
Reviewers