Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: add cbor module in the requirement.txt #12358

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

jamesbeyond
Copy link
Contributor

Summary of changes

In PullRequest : #12231
cbor module is used in https://github.com/ARMmbed/mbed-os/blob/master/tools/psa/tfm/bin_utils/imgtool_lib/boot_record.py#L21

However, the module wasn't installed by default. building targets like ARM_MUSCA_A1_NS is failing
So adding this module to requirements.txt

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@Devran01 @VeliMattiLahtela

@ciarmcom ciarmcom requested review from urutva, VeliMattiLahtela and a team February 3, 2020 18:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 3, 2020

@jamesbeyond, thank you for your changes.
@VeliMattiLahtela @Devran01 @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Feb 4, 2020
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 4, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

Thanks for fixing the nightly for MUSCA target

@mergify mergify bot added needs: work and removed needs: CI labels Feb 4, 2020
@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

I haven't seen this error for some time tools.utils.ToolException: Compile did not finish in 10 minutes

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 4, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 4, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@jamesbeyond
Copy link
Contributor Author

odd failure, I am checking it out

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 10, 2020

Any update for the failures?

@jamesbeyond
Copy link
Contributor Author

Any update for the failures?

I think that's some CI issue, will try to have a catch-up with Veli-Matti to resolve that

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 12, 2020

Can we get it in this week to fix nightly build for this target?

@jamesbeyond
Copy link
Contributor Author

I think this is fixed in the Infra side by @VeliMattiLahtela

@jamesbeyond
Copy link
Contributor Author

CI restarted

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2020

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM

@mbed-ci
Copy link

mbed-ci commented Feb 24, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@jamesbeyond
Copy link
Contributor Author

Hey @0xc0170 , I think CI cache got cleared, finally, this PR should be good to go

@0xc0170 0xc0170 merged commit 1e24c00 into ARMmbed:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants