Skip to content

Conversation

jamesbeyond
Copy link
Contributor

Summary of changes

This fix the bug in ATCmdParser test, where the number of arguments does not match with the format specifier. This caused a segfault on Mac OS.

and this is reported in #12346

Impact of changes

Migration actions required

Documentation

Documents not needed


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested review from a team February 7, 2020 02:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 7, 2020

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 7, 2020
@0xc0170 0xc0170 requested a review from a team February 7, 2020 11:44
@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 7, 2020

Test run: SUCCESS

Summary: 1 of 1 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit da7c641 into ARMmbed:master Feb 10, 2020
@mergify mergify bot removed the ready for merge label Feb 10, 2020
@jamesbeyond jamesbeyond deleted the unittest-fix branch February 10, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants