I2CEEBlockdevice: fix i2c read return value #12395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading a data block, the returned error codes from the I2C subsystem are different from normal single byte operations. We have to verify that the read-function for multiple bytes does return zero, because it returns "readBytes != expectedLength". Additionally, sync before trying to read from the eeprom as slow devices may not yet be ready to return data, especially with low-priced ones used with fast controllers.
|
@boomer41, thank you for your changes. |
SeppoTakalo
reviewed
Feb 10, 2020
components/storage/blockdevice/COMPONENT_I2CEE/I2CEEBlockDevice.cpp
Outdated
Show resolved
Hide resolved
SeppoTakalo
approved these changes
Feb 10, 2020
0xc0170
approved these changes
Feb 10, 2020
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
0xc0170
added
the
release-version: 6.0.0-alpha-2
0xc0170
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When reading a data block, the returned error codes from the I2C subsystem
are different from normal single byte operations. We have to verify that
the read-function for multiple bytes does return zero, because it
returns "readBytes != expectedLength".
Additionally, sync before trying to read from the eeprom as slow devices
may not yet be ready to return data, especially with low-priced ones used
with fast controllers.
Documentation
No update needed.
Pull request type
Test results