Skip to content

Conversation

rajkan01
Copy link
Contributor

Summary of changes

The Arm Compiler 5 is no longer supported so removed the deprecate warning and added the exception in the build tool to stop building with ARM compiler 5.

Impact of changes

With these changes, Arm compiler 5 build fails

Migration actions required

Upgrade the enviroment to use Arm Compiler 6 refer

Documentation


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @madchutney


@ciarmcom ciarmcom requested review from evedon, madchutney and a team February 10, 2020 14:00
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@madchutney @evedon @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Feb 10, 2020
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this warning-error all we need do - there is still code related to ARM5 in the tools/targets, we remove it separately but still within 6.0 version?

@mark-edgeworth
Copy link
Contributor

There are currently 68 references to ARMC5 in mbed-os. What is the plan to remove these?

@0xc0170 0xc0170 added the release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 label Feb 11, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2020

Started CI while we complete the review

@mbed-ci
Copy link

mbed-ci commented Feb 11, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 11, 2020

Not yet ready for integration, @bulislaw Please approve

@0xc0170 0xc0170 requested a review from bulislaw February 11, 2020 11:47
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first step, but I'd like us to remove all the dead code that's there for ARMC5 support and compatibility.

@0xc0170 0xc0170 merged commit bb86c0e into ARMmbed:master Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING-CHANGE release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants