Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32F4 update drivers version to CUBE V1.25.0 #12626

Merged
merged 5 commits into from
Apr 1, 2020
Merged

STM32F4 update drivers version to CUBE V1.25.0 #12626

merged 5 commits into from
Apr 1, 2020

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented Mar 13, 2020 •
edited by adbridge
Loading

Summary of changes

ST Cube drivers version is updated from V1.19.0 to V1.25.0,
which is the latest official version from:
https://github.com/STMicroelectronics/STM32CubeF4

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ST CI tests executed for:

  • all ST boards
  • all tool chains
  • CI shield

Reviewers

@ARMmbed/team-st-mcd

@ciarmcom ciarmcom requested a review from a team March 13, 2020 16:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Mar 16, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Mar 16, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 16, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 16, 2020

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 16, 2020

The failure in one of ublox targets, ./mbed-os/features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/aes_alt.c:132:28: error: use of undeclared identifier 'HAL_CRYP_PHASE_READY'; did you mean 'HAL_CRYP_STATE_READY'?

@mergify mergify bot dismissed 0xc0170’s stale review March 17, 2020 07:37

Pull request has been modified.

@jeromecoutant
Copy link
Collaborator Author

The failure in one of ublox targets

Corrected

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 17, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2020

Test run: SUCCESS

Summary: 8 of 8 test jobs passed
Build number : 2
Build artifacts

0xc0170
0xc0170 previously approved these changes Mar 17, 2020
View reviewed changes
@0xc0170 0xc0170 requested a review from a team March 17, 2020 14:40
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 17, 2020

@ARMmbed/mbed-os-crypto please review features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/aes_alt.c and other related changes here

@mergify mergify bot dismissed 0xc0170’s stale review March 19, 2020 17:45

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

CI restarted

@mergify mergify bot dismissed Patater’s stale review March 27, 2020 10:29

Pull request has been modified.

@adbridge
Copy link
Contributor

@0xc0170 @Patater are you happy with the updates? If so please approve.

@mergify
Copy link

mergify bot commented Mar 30, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Patater
Patater reviewed Mar 31, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit "STM32F4 V1.19.0 -> V1.25.0 : MBEDTLS adaptation" seems fine. Just style issues

features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/aes_alt.c Outdated Show resolved Hide resolved
features/mbedtls/targets/TARGET_STM/TARGET_STM32F4/aes_alt.c Outdated Show resolved Hide resolved
@adbridge
Copy link
Contributor

@Patater are you ok with this now ?

Patater
Patater approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit "STM32F4 V1.19.0 -> V1.25.0 : MBEDTLS adaptation" LGTM

No other commits reviewed

@mergify mergify bot added needs: CI and removed needs: work labels Mar 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 1, 2020

Test run: FAILED

Summary: 1 of 7 test jobs failed
Build number : 4
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test

@0xc0170 0xc0170 merged commit a6ef9db into ARMmbed:master Apr 1, 2020
@mergify mergify bot removed the ready for merge label Apr 1, 2020
@jeromecoutant jeromecoutant deleted the PR_F4 branch April 1, 2020 12:07
This was referenced May 5, 2020
Closed
Merged
@jeromecoutant jeromecoutant mentioned this pull request Jun 16, 2020
Closed
@jeromecoutant jeromecoutant mentioned this pull request Nov 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patater Patater Patater approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
No open projects
Pull request triage
  
needs: work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @adbridge @Patater @JojoS62