New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated netsocket methods #12685
Merged
0xc0170
merged 3 commits into
ARMmbed:master
from
kivaisan:remove_deprecated_netsocket_methods
Mar 25, 2020
Merged
Remove deprecated netsocket methods #12685
0xc0170
merged 3 commits into
ARMmbed:master
from
kivaisan:remove_deprecated_netsocket_methods
Mar 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InternetSocket::sigio should be used instead.
Default constructor and separate open call should be used instead.
Default constructor with separate open call should be used instead.
@kivaisan, thank you for your changes. |
AnttiKauppila
approved these changes
Mar 24, 2020
michalpasztamobica
approved these changes
Mar 24, 2020
I edited Impact of changes to define details what is being deprecated. |
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
0xc0170
approved these changes
Mar 24, 2020
bulislaw
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Remove deprecated methods from netsocket
Impact of changes
Deprecated methods in netsocket (since Mbed OS 5.1) are removed.
Migration actions required
InternetSocket::attach
-> UseSocket::sigio
TCPSocket(S *stack)
-> Use defaultTCPSocket
constructor and callopen
separatelyUDPSocket(S *stack)
-> Use defaultUDPSocket
constructor and callopen
separatelyDocumentation
n/a
Pull request type
Test results
Reviewers