Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated netsocket methods #12685

Merged
merged 3 commits into from Mar 25, 2020
Merged

Remove deprecated netsocket methods #12685

merged 3 commits into from Mar 25, 2020

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Mar 24, 2020

Summary of changes

Remove deprecated methods from netsocket

Impact of changes

Deprecated methods in netsocket (since Mbed OS 5.1) are removed.

Migration actions required

InternetSocket::attach -> Use Socket::sigio
TCPSocket(S *stack) -> Use default TCPSocket constructor and call open separately
UDPSocket(S *stack) -> Use default UDPSocket constructor and call open separately

Documentation

n/a


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Kimmo Vaisanen added 3 commits March 24, 2020 12:46
InternetSocket::sigio should be used instead.
Default constructor and separate open call should be used instead.
Default constructor with separate open call should be used instead.
@ciarmcom ciarmcom requested review from a team March 24, 2020 12:00
@ciarmcom
Copy link
Member

@kivaisan, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Mar 24, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

Deprecated methods in netsocket (since Mbed OS 5.11) are removed.

I edited Impact of changes to define details what is being deprecated.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added this to To do in Pull request triage Mar 25, 2020
Pull request triage automation moved this from needs: review to needs: CI Mar 25, 2020
@0xc0170 0xc0170 merged commit b62fdae into ARMmbed:master Mar 25, 2020
@mergify mergify bot removed the ready for merge label Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Pull request triage
  
needs: CI
Development

Successfully merging this pull request may close these issues.

None yet

7 participants