Skip to content

Mbedtls fixes #12729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 3, 2020
Merged

Mbedtls fixes #12729

merged 8 commits into from
Apr 3, 2020

Conversation

AnttiKauppila
Copy link

Summary of changes

This is a preparation PR for upcoming MbedTLS optimisation changes.
In the commits there are mostly flagged out code and this must not break anything.

Impact of changes

Migration actions required

Documentation

None, optimisations will be documented in MbedTLS optimisation release

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@AnttiKauppila AnttiKauppila mentioned this pull request Mar 31, 2020
Closed
JanneKiiskila
JanneKiiskila reviewed Mar 31, 2020
View reviewed changes
JanneKiiskila
JanneKiiskila reviewed Mar 31, 2020
View reviewed changes
0xc0170
0xc0170 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving all comments

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 31, 2020

jenkins-ci/wisun-mesh-test — Error

@ARMmbed/mbed-os-test please review this test error

@mergify mergify bot added needs: work and removed needs: CI labels Mar 31, 2020
@mbed-ci
Copy link

mbed-ci commented Mar 31, 2020

Test run: FAILED

Summary: 2 of 7 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_wisun-mesh-test
  • jenkins-ci/mbed-os-ci_cloud-client-pytest

@AnttiKauppila
Copy link
Author

@mikter Any idea what might cause WiSun test failure?

@AnttiKauppila
Copy link
Author

@teetak01 Any thoughts on client test failures?

@artokin
Copy link
Contributor

artokin commented Apr 1, 2020 •
edited
Loading

Wi-SUN tests are failing because we are using deprecated API in nanostack-border-router. Some deprecated APIs have been removed from Mbed OS lately and therefore this error occurs.

However, a fix was delivered about 2 hours ago and Wi-SUN tests should be working now.

@Patater
Copy link
Contributor

Patater commented Apr 1, 2020

Any action required on #12479 (comment) ?

@AnttiKauppila
Copy link
Author

Any action required on #12479 (comment) ?

I have added the check Kimmo suggested

Patater
Patater approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@Patater Patater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me, given we are limiting support for this configuration of Mbed TLS to Mbed OS baremetal mode only.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 2, 2020

I restarted tests

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts

@mergify mergify bot removed the needs: CI label Apr 3, 2020
@0xc0170 0xc0170 merged commit 74ace63 into ARMmbed:master Apr 3, 2020
@mergify mergify bot removed the ready for merge label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@Patater Patater Patater approved these changes

@JanneKiiskila JanneKiiskila JanneKiiskila left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AnttiKauppila @0xc0170 @mbed-ci @artokin @Patater @JanneKiiskila