Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change files in TARGET_SDT64B #12744

Merged
merged 2 commits into from Apr 6, 2020
Merged

Change files in TARGET_SDT64B #12744

merged 2 commits into from Apr 6, 2020

Conversation

heejungPark
Copy link

Summary of changes

Because SDT64B inherited characteristics from FRDM_K64F, files in TARGET_SDT64B need to be changed to have same file list or format with TARGET_FRDM.

Impact of changes

I think that it is no problems if K64F has no problems.

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested review from maclobdell and a team April 2, 2020 03:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 2, 2020

@heejungPark, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously requested changes Apr 2, 2020
View reviewed changes
...ts/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_SDT64B/PeripheralPinMaps.h
@@ -0,0 +1,374 @@
/* mbed Microcontroller Library
* Copyright (c) 2006-2013 ARM Limited
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add SPDX identifier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it. Please check.

Update PeripheralPinMaps.h
7cb2344 
Add SPDX identifier
@mergify mergify bot dismissed 0xc0170’s stale review April 2, 2020 11:09

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 5, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 4b3cddf into ARMmbed:master Apr 6, 2020
@mergify mergify bot removed the ready for merge label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heejungPark @ciarmcom @0xc0170 @mbed-ci