PSoC 62/63: set correct mbed_ram_start and mbed_ram_size #12752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case when target.mbed_ram_start and target.mbed_ram_size are not set neither in targets.json nor in mbed_app.json, the IRAM1 region values defined in tools/arm_pack_manager/index.json are passed by Mbed CLI as the linker script preprocessing flags. As a result, wrong addresses of MBED_RAM_START and MBED_RAM_SIZE are defined in the linker script since CMSIS DFP pack has no information about RAM split between CM0+ and CM4 applications. Set the values explicitly in targets.json to ensure the correct RAM layout. The MBED_ROM_START and MBED_ROM_SIZE provided by CMSIS DFP are already correct since the linker scripts places CM4 vector table at MBED_APP_START, taking into account the flash application area of the CM0+ prebuilt application.
|
@vmedcy, thank you for your changes. |
0xc0170
approved these changes
Apr 3, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 6 test jobs failed Failed test jobs:
|
|
Test failures look like they were unrelated to these changes. Can you start the CI job again? |
|
CI restarted |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In case when target.mbed_ram_start and target.mbed_ram_size are not set
neither in targets.json nor in mbed_app.json, the IRAM1 region values
defined in tools/arm_pack_manager/index.json are passed by Mbed CLI as
the linker script preprocessing flags. As a result, wrong addresses of
MBED_RAM_START and MBED_RAM_SIZE are defined in the linker script since
CMSIS DFP pack has no information about RAM split between CM0+ and CM4 applications.
Set the values explicitly in targets.json to ensure the correct RAM layout.
The MBED_ROM_START and MBED_ROM_SIZE provided by CMSIS DFP are already
correct since the linker scripts places CM4 vector table at MBED_APP_START,
taking into account the flash application area of the CM0+ prebuilt application.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers