Skip to content

ESP8266 Drv support baud-rate switch #12768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

ESP8266 WiFi module default baud-rate is 115200, this PR is to support the baud-rate switch from default baud-rate to the target baud-rate.

Documentation

None

Pull request type

[v] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[v] Tests / results supplied as part of this PR

test-log.txt


Reviewers

@michalpasztamobica

@mergify mergify bot added the needs: work label Apr 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2020

Please fix the style issue

@michalpasztamobica
Copy link
Contributor

Hi @cyliangtw . We are already calling AT+UART_CUR on startup in stop_uart_hw_flow_ctrl(). This is also visible in the logs you attached...
Can you please explain how this PR improves the current behavior?

@ciarmcom ciarmcom requested review from michalpasztamobica and a team April 7, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Apr 7, 2020

@cyliangtw, thank you for your changes.
@michalpasztamobica @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

@cyliangtw
Copy link
Contributor Author

cyliangtw commented Apr 7, 2020

@michalpasztamobica, if some platform not support flow control, stop_uart_hw_flow_ctrl() will not work.
More, if the original instructor set serial obj baud != 115200, later _parser.send() can't communicate with wifi module caused by the un-matching baud-rate.

@michalpasztamobica
Copy link
Contributor

Thanks for the explanation. This makes sense to me now and I also verified that actually setting baud rate different than default did not work and the code on your branch fixes the issue.

Thanks a lot for this contribution!

@michalpasztamobica
Copy link
Contributor

Fixes #12710

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 07872bc into ARMmbed:master Apr 15, 2020
@mergify mergify bot removed the ready for merge label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants