Cellular: Disable AT traces when mbed-trace is disabled #12817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier if mbed-trace was disabled but debug-at enabled, some AT trace codes were still enabled causing unnecessary code size increase. This commit fixes the issue that AT debug trace code is enabled only when both mbed-trace.enable and cellular.debug-at are enabled. Reduces binary size by about ~340bytes when mbed-trace is disabled but debug-at enabled.
AnttiKauppila
approved these changes
Apr 16, 2020
0xc0170
approved these changes
Apr 16, 2020
|
CI started |
Test run: SUCCESSSummary: 6 of 6 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Earlier if mbed-trace was disabled but
cellular.debug-atenabled, some AT trace codes were stillenabled causing unnecessary code size increase.
This commit fixes the issue that AT debug trace code is enabled only when both
mbed-trace.enableandcellular.debug-atare enabled.Reduces binary size by about ~340 bytes when mbed-trace is disabled but debug-at enabled.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-wan