Skip to content

[SX1272 & SX1276 Driver] Fix Fifo Pointer in Continuous Mode #12890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020
Merged

[SX1272 & SX1276 Driver] Fix Fifo Pointer in Continuous Mode #12890

merged 1 commit into from
May 12, 2020

Conversation

Eric-A-Marks
Copy link
Contributor

Summary of changes

In continuous mode we need to check and set the fifo pointer before every read, otherwise data may be lost.

This is bug is commonly seen when using the mbed LoRaWAN FUOTA demo as small delta updates working, but large full updates failing.

https://github.com/ARMmbed/mbed-os-example-lorawan-fuota/


Documentation

ARMmbed/mbed-semtech-lora-rf-drivers#56


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

In continuous mode we need to check and set the fifo pointer before every read, otherwise data may be lost.
@ciarmcom
Copy link
Member

@Eric-A-Marks, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 29, 2020 19:00
@mbed-ci
Copy link

mbed-ci commented May 4, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

Will be merged as soon as we have 6.0.0 beta1 released

@0xc0170 0xc0170 merged commit 18d00e9 into ARMmbed:master May 12, 2020
@mergify mergify bot removed the ready for merge label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants