Skip to content

Fix the USB MSD greentea host side pyusb_msd.py script #12944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented May 7, 2020

Summary of changes

Removed the redundant unicode to byte string conversion from _disk_path_windows function on pyusb_msd.py script as comparing expected input disk serial number and mounted disk on host serial number of type unicode string so it can work on both python2 and python3.

Fixes #12807

Impact of changes

With these changes, USB msd greentea host-side part of the test runs under either python2 or python3.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon


@ciarmcom ciarmcom requested review from evedon and a team May 7, 2020 19:00
@ciarmcom
Copy link
Member

ciarmcom commented May 7, 2020

@rajkan01, thank you for your changes.
@evedon @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 8, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 8, 2020

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USB msd test is faiiling on python 3
5 participants