Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: targets json rework #12959

Merged
merged 3 commits into from
May 12, 2020
Merged

STM32: targets json rework #12959

merged 3 commits into from
May 12, 2020

Conversation

jeromecoutant
Copy link
Collaborator

@jeromecoutant jeromecoutant commented May 12, 2020 •
edited
Loading

Summary of changes

Hi

There is no change with this PR, only rework

  • "FAMILY_STM32" name is replaced by "MCU_STM32" name as expected by mbed rules
  • all STM32 targets are now reordered with alphabetical MCU chip order

// edit

  • creation of MCU_STM32_BAREMETAL

Thx

Impact of changes

none

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant
Copy link
Collaborator Author

@MarceloSalazar
@ARMmbed/team-st-mcd

@ciarmcom ciarmcom requested a review from a team May 12, 2020 13:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels May 12, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented May 12, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented May 12, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit a4f6645 into ARMmbed:master May 12, 2020
@mergify mergify bot removed the ready for merge label May 12, 2020
@jeromecoutant jeromecoutant deleted the PR_TARGETS_JSON branch May 12, 2020 16:38
evedon
evedon reviewed May 12, 2020
View reviewed changes
targets/targets.json
]
},
"c_lib": "small",
"supported_application_profiles": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add "supported_application_profiles" : ["bare-metal", "full"] to all targets in a subsequent PR.

@evedon
Copy link
Contributor

evedon commented May 12, 2020

Changes look good.

jeromecoutant
jeromecoutant commented May 13, 2020
View reviewed changes
targets/targets.json
Comment on lines +1316 to +1326
"supported_c_libs": {
"arm": [
"small"
],
"gcc_arm": [
"small"
],
"iar": [
"std"
]
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed ?
Maybe only "c_lib": "small" is sufficient ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evedon evedon evedon left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @evedon