Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix capacity check when service data are added to BLE advertising payload #13035

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Fix capacity check when service data are added to BLE advertising payload #13035

merged 1 commit into from
Jun 5, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented May 29, 2020

…load.

Summary of changes

This change address a wrong computation made to ensure there is enough space to hold service data in a BLE advertising payload.

Impact of changes

Fixes ARMmbed/mbed-os-example-ble#267

Documentation

None

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm

@ciarmcom ciarmcom requested review from paul-szczepanek-arm and a team May 29, 2020 15:00
@ciarmcom
Copy link
Member

@pan-, thank you for your changes.
@paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 2, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 5, 2020
@0xc0170 0xc0170 changed the title Fix capacity check when service data are added to BLE advertising pay… Fix capacity check when service data are added to BLE advertising payload Jun 5, 2020
@0xc0170 0xc0170 merged commit c7cf9a9 into ARMmbed:master Jun 5, 2020
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sending more than 13 bytes payload in adv packet causes BUFFER_OVERFLOW.
6 participants
@pan- @ciarmcom @0xc0170 @mbed-ci @paul-szczepanek-arm @adbridge