Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordio: put parentheses to correct order of precedence in ternary expressions #13041

Merged
merged 1 commit into from Jun 5, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Put parentheses to correct the order of precedence in ternary expressions. This was highlighted by build warnings.

Impact of changes

Fix Cordio bug.

Migration actions required

N/A

Documentation

N/A


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm @pan-


…ressions

Also remove extraneous parentheses in comparison.
@ciarmcom ciarmcom requested review from pan-, paul-szczepanek-arm and a team May 29, 2020 19:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@pan- @paul-szczepanek-arm @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 3, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 5, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 5, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 5, 2020
@0xc0170 0xc0170 merged commit 35a0e5d into ARMmbed:master Jun 5, 2020
@mergify mergify bot removed the ready for merge label Jun 5, 2020
@mergify
Copy link

mergify bot commented Jun 5, 2020

This PR does not contain release version label after merging.

@mergify mergify bot added the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 5, 2020
@hugueskamba hugueskamba deleted the hk_remove_cordio_warnings branch June 5, 2020 23:53
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
@0xc0170 0xc0170 removed the release version missing When PR does not contain release version, bot should label it and we fix it afterwards label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants