Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbed-os-5.15] Allowed to set Wi-SUN certificates in DISCONNECTED state #13072

Merged
merged 1 commit into from
Jun 12, 2020
Merged

[mbed-os-5.15] Allowed to set Wi-SUN certificates in DISCONNECTED state #13072

merged 1 commit into from
Jun 12, 2020

Conversation

mikter
Copy link

@mikter mikter commented Jun 5, 2020

Summary of changes

Allow setting of Wi-SUN certificates after disconnect for the reconnection.
Support changing of certificates when stack is already running.

backport for PR: #13048

Impact of changes

This only extends the usability of the API allowing new way to use the interface

Migration actions required

No Actions

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

Allowed to set Wi-SUN certificates in DISCONNECTED state
bd00cf1 
Before certificates were able to set only once.
Now after disconnect those can be set Again

Also those can be set when stack is active
@mikter mikter changed the title Allowed to set Wi-SUN certificates in DISCONNECTED state [mbed-os-5.15] Allowed to set Wi-SUN certificates in DISCONNECTED state Jun 5, 2020
@mikter mikter requested a review from artokin June 5, 2020 09:54
@ciarmcom ciarmcom requested a review from a team June 5, 2020 11:00
@ciarmcom
Copy link
Member

ciarmcom commented Jun 5, 2020

@mikter, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 8, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 8, 2020

CI started

@0xc0170 0xc0170 requested a review from andypowers June 8, 2020 11:25
@mbed-ci
Copy link

mbed-ci commented Jun 8, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@adbridge
Copy link
Contributor

Will re-run ci as this was last run several days ago

@mbed-ci
Copy link

mbed-ci commented Jun 11, 2020

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM-lts

@adbridge
Copy link
Contributor

@mikter Could you check the CI failures please ?

@artokin
Copy link
Contributor

artokin commented Jun 12, 2020

@adbridge , it seems to be a CI flaw. I retriggered failing job https://mbed-os.mbedcloudtesting.com/job/mbed-os-ci_build-GCC_ARM-lts/160/ (build 162) and it is passing now. Unfortunately the status is not updated to this PR properly.

@adbridge
Copy link
Contributor

@artokin I'll rerun the whole chain and see if that does the trick

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2020

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM-lts

@mbed-ci
Copy link

mbed-ci commented Jun 12, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 4
Build artifacts

@adbridge adbridge merged commit 0515ed1 into ARMmbed:mbed-os-5.15 Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@artokin artokin artokin approved these changes

@andypowers andypowers Awaiting requested review from andypowers

Assignees
No one assigned
Labels
mergify skip release-version: 5.15.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mikter @ciarmcom @0xc0170 @mbed-ci @adbridge @artokin