Skip to content

Fix compliation warnings #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2020
Merged

Fix compliation warnings #13117

merged 1 commit into from
Jun 16, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 15, 2020 •
edited
Loading

Summary of changes

Removed the unused variable from kvstore function _calculate_blocksize_match_tdbstore() to fix compilation warning.

Impact of changes

With these changes, no more compilation warning get reported during the build.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Jun 15, 2020
0xc0170
0xc0170 previously requested changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove spaces (astyle job failures)

@rajkan01 rajkan01 force-pushed the fix_kvstore_compilation_warning branch from ea8b19c to face8ec Compare June 15, 2020 13:01
@rajkan01
Copy link
Contributor Author

Remove spaces (astyle job failures)

Done.

@mergify mergify bot dismissed 0xc0170’s stale review June 15, 2020 13:01

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 15, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 16, 2020
@0xc0170 0xc0170 merged commit 8e91988 into ARMmbed:master Jun 16, 2020
@mergify mergify bot removed the ready for merge label Jun 16, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajkan01 @0xc0170 @mbed-ci @LDong-Arm @adbridge