Skip to content

STM32H7: correct Ethernet issue in baremetal #13143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2020
Merged

STM32H7: correct Ethernet issue in baremetal #13143

merged 1 commit into from
Jun 18, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

There was some build issue with mbed-os-example-blinky-baremetal and STM32H7 boards.

@MarceloSalazar

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team June 17, 2020 17:00
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

MarceloSalazar
MarceloSalazar reviewed Jun 17, 2020
View reviewed changes
targets/TARGET_STM/TARGET_STM32H7/STM32Cube_FW/stm32h7xx_hal_conf.h
#else
/* ex: bare metal profile */
#define ETH_TX_DESC_CNT 0 /* Tx buffers of size ETH_TX_BUF_SIZE */
#define ETH_RX_DESC_CNT 0 /* Rx buffers of size ETH_RX_BUF_SIZE */
Copy link

@MarceloSalazar MarceloSalazar Jun 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "0" mean?
Is Ethernet expected to work on Baremetal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, Ethernet needs threads

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! then it might be better to disable ethernet rather than silently compiling, right?
And perhaps if the network API is used in bare-metal, there should be an error (I'm not sure where exactly the check should be introduced but it might be a tools/build-system enhancement).
For reference: https://os.mbed.com/docs/mbed-os/v6.0/bare-metal/index.html

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Ethernet is disabled with baremetal, but Ethernet ST Cube drivers are compiled.
And these 2 macro ETH_RX/TX_DESC_CNT are used in ST files. Definition were defined at ST Cube level, but I moved them in emac directory for mbed. So we need to redefine it when emac is not present.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromecoutant might be useful to have the reason for having this set to 0 in the commit message - does that mean no allocated memory as they are 0 or symbols are protected somehow? I've already started CI ,can restart later

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As emac is disabled, you can set the value you want....

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 18, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Jun 18, 2020
@0xc0170 0xc0170 added the release-type: patch Indentifies a PR as containing just a patch label Jun 18, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 18, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit e9b1df6 into ARMmbed:master Jun 18, 2020
@mergify mergify bot removed the ready for merge label Jun 18, 2020
@jeromecoutant jeromecoutant deleted the PR_H7_BARE branch June 18, 2020 08:27
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@MarceloSalazar MarceloSalazar MarceloSalazar left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @MarceloSalazar @adbridge