Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mbed-coap to connectivity/libraries #13255

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Conversation

LDong-Arm
Copy link
Contributor

@LDong-Arm LDong-Arm commented Jul 8, 2020

Summary of changes

As per our new directory structure proposal, this PR moves mbed-coap from features/frameworks into connectivity/libraries.

Impact of changes

Migration actions required

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

nanostack-border-router compiles for K64F. Unit tests continue to work.


Reviewers

@ARMmbed/mbed-os-core @bulislaw @0xc0170


@mergify mergify bot added the needs: work label Jul 8, 2020
@ciarmcom ciarmcom requested a review from a team July 8, 2020 17:00
@ciarmcom
Copy link
Member

ciarmcom commented Jul 8, 2020

@LDong-Arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@pan-
Copy link
Member

pan- commented Jul 9, 2020

There is now two PRs to move mbed-coap some place else: #12962

@LDong-Arm
Copy link
Contributor Author

There is now two PRs to move mbed-coap some place else: #12962

My PR is to put mbed-coap in the place we agreed - connectivity/libraries/mbed-coap. Once it gets in, #12962 can then be reworked to do connectivity/libraries/mbed-coap -> connectivity/libraries/FEATURE_MBED_COAP/ as its main point is to use the "FEATURE_..." magic name.

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evedon
Copy link
Contributor

evedon commented Jul 16, 2020

There is now two PRs to move mbed-coap some place else: #12962

My PR is to put mbed-coap in the place we agreed - connectivity/libraries/mbed-coap. Once it gets in, #12962 can then be reworked to do connectivity/libraries/mbed-coap -> connectivity/libraries/FEATURE_MBED_COAP/ as its main point is to use the "FEATURE_..." magic name.

I don't think we want to use "FEATURE_..." magic name going forward.

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Jul 17, 2020

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 1
Build artifacts

@adbridge adbridge merged commit 63655e8 into ARMmbed:master Jul 17, 2020
@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed ready for merge labels Jul 17, 2020
@mbedmain mbedmain added release-version: 6.2.1 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants