Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CYSBSYSKIT_01 #13416

Merged
merged 5 commits into from Aug 26, 2020
Merged

Conversation

dustin-crossman
Copy link
Contributor

@dustin-crossman dustin-crossman commented Aug 11, 2020

Summary of changes

Updates COMPONENT_SCL to support WiFi SCAN.
Updates board assets and linker scripts

Impact of changes

Migration actions required

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

08_06_MCUBoot-mbed-os-6.2.0.txt

Test failure explanations:

  • Watchdog/reset related failures: These fail due to the custom CM0 application (see Add target CYSBSYSKIT_01 #12603 for background) taking longer than normal to start up, causing an infinite watchdog reset loop. Setting the reset duration to be longer fixes these failures.
  • All others: All other failures are related to deep sleep. Currently the CM0 image on this board does not support deep sleep and thus locks deep sleep capability.

Reviewers


@ciarmcom
Copy link
Member

@dustin-crossman, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2020

Please review travis failures, related to the target (missing sectors).

@adbridge
Copy link
Contributor

adbridge commented Aug 12, 2020

@dustin-crossman please note, target updates are not features . Unless you are changing an mbed-os api etc then these should be patches. Also considering code freeze is tomorrow, this has landed a little late...One futher point, you cannot assume what the next release version will be as the version is determined by the content which has landed by the time we hit code freeze. Could you please update the PR title accordingly. Thanks.

@dustin-crossman dustin-crossman changed the title Update CYSBSYSKIT_01 for 6.2.1 Update CYSBSYSKIT_01 Aug 12, 2020
@dustin-crossman
Copy link
Contributor Author

@adbridge Good point on the versioning. Title and PR type updated.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

@dustin-crossman if you can resolve failures in tools today, we can restart CI and get this in for the upcoming release (code freeze today)

@dustin-crossman
Copy link
Contributor Author

@0xc0170 Sectors info added in! Hopefully that resolves the CI failures.

0xc0170
0xc0170 previously approved these changes Aug 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 13, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Aug 13, 2020
@mbed-ci
Copy link

mbed-ci commented Aug 13, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2020

@dustin-crossman test passed but travis did not, can you verify?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2020

I restarted. sectors are present in target.json, I am not seeing why it would assert now :/

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2020

@dustin-crossman We would like to code freeze the next release today. Shall we postpone this to the next one?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 14, 2020

cc @ARMmbed/team-cypress ^^

@dustin-crossman
Copy link
Contributor Author

I think it wants the sectors to be in the tools/arm_pack_manager/index.json instead of just the targets.json. Yea lets postpone this to the next one.

@mergify mergify bot dismissed 0xc0170’s stale review August 18, 2020 16:46

Pull request has been modified.

@dustin-crossman
Copy link
Contributor Author

Added sectors info the arm_pack_manager/index.json. Looks like that fixed up the CI issues.

@dustin-crossman
Copy link
Contributor Author

@0xc0170 Does this look ready to go with the CI issues fixed up?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 25, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 25, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 555c7db into ARMmbed:master Aug 26, 2020
@mergify mergify bot removed the ready for merge label Aug 26, 2020
@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Sep 10, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants