Skip to content

mbed-os-5.15: Nuvoton: Fixed NUC472 SD buffer alignment #13512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2020
Merged

mbed-os-5.15: Nuvoton: Fixed NUC472 SD buffer alignment #13512

merged 1 commit into from
Oct 13, 2020

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

This PR is to correct NUC472 SD buffer alignment as 4 bytes instead of original 4K, it could resolve the issue
of mbed-os-example-pelion NUC472 GCC build failed in Pelion PR #147

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar
@teetak01

@cyliangtw cyliangtw mentioned this pull request Aug 31, 2020
Closed
@ciarmcom ciarmcom requested review from MarceloSalazar, teetak01 and a team August 31, 2020 05:30
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@teetak01 @MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@cyliangtw
Copy link
Contributor Author

@ciarmcom
CI build can't complete due to "arm-none-eabi-gcc is currently not installed" in your build-machine.
Please help to check it.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

There is another PR fixing gcc arm version, once it is in, I'll restart all 5.15 PRs.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 1, 2020

Travis passed, perfect, I'll run CI for 5.15 jobs later today.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from andypowers September 2, 2020 15:08
@0xc0170 0xc0170 changed the title [mbed-os-5.15] Nuvoton: Fixed NUC472 SD buffer alignment mbed-os-5.15: Nuvoton: Fixed NUC472 SD buffer alignment Sep 29, 2020
andypowers
andypowers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ccli8
Copy link
Contributor

ccli8 commented Oct 8, 2020

Update?

@0xc0170 0xc0170 merged commit f63b4b6 into ARMmbed:mbed-os-5.15 Oct 13, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

@ccli8 Thanks for the reminder, we are now processing remaining 5.15 PRs to update all of them

@mergify mergify bot removed the ready for merge label Oct 13, 2020
@cyliangtw cyliangtw deleted the nvt_nuc472_sd_5.15 branch December 6, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@teetak01 teetak01 teetak01 approved these changes

@andypowers andypowers andypowers approved these changes

@MarceloSalazar MarceloSalazar Awaiting requested review from MarceloSalazar

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cyliangtw @ciarmcom @0xc0170 @mbed-ci @ccli8 @teetak01 @andypowers