Skip to content

STM32 USB connect procedure update #13522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

USB tests restarted during #13406

Tested with:

  • STM32F1: Need external Pull up on USB DP
  • STM32WB: Non regression OK, Internal pull up on DP pin OK
  • STM32L4: Non regression OK

@Allmoz
@maciejbocianski

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Pull up on USB DP to manage (external for STM32F1)
@jeromecoutant jeromecoutant mentioned this pull request Sep 1, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 1, 2020
@ciarmcom ciarmcom requested a review from a team September 1, 2020 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Sep 1, 2020

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Sep 2, 2020
@maciejbocianski
Copy link
Contributor

@jeromecoutant what actually it changes to wb55? It's worth backporting ?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@jeromecoutant
Copy link
Collaborator Author

what actually it changes to wb55? It's worth backporting ?

I agree this should not impact STM32WB.
This align code and USB behavior between STM32 families.

@0xc0170 0xc0170 merged commit 2eb2fe4 into ARMmbed:master Sep 3, 2020
@mergify mergify bot removed the ready for merge label Sep 3, 2020
@jeromecoutant jeromecoutant deleted the PR_USB_PULLUP branch September 3, 2020 12:26
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants