allow host resolved address to be used for connection #13685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paul-szczepanek-arm, thank you for your changes. |
| #if BLE_GAP_HOST_BASED_PRIVATE_ADDRESS_RESOLUTION | ||
| if (_connect_to_address_type != peer_address_type_t::ANONYMOUS) { | ||
| ret = startScan( | ||
| (scan_duration_t)connectionParams.getConnectionSupervisionTimeoutArray()[0], |
There was a problem hiding this comment.
this is probably not the right value to use
paul-szczepanek-arm
force-pushed
the
host-privacy-feature
branch
from
3c8bfb8 to
267c360
Compare
pan-
reviewed
Sep 30, 2020
| @@ -521,6 +525,17 @@ ble_error_t Gap::connect( | |||
|
|
|||
| ble_error_t ret = BLE_ERROR_INTERNAL_STACK_FAILURE; | |||
|
|
|||
| #if BLE_GAP_HOST_BASED_PRIVATE_ADDRESS_RESOLUTION | |||
| if (_ready_to_connect_to_host_resolved_address) { | |||
There was a problem hiding this comment.
It took me some time to understand what this exactly does. Using a state enum would make the code more readable and prevent multiple calls to connect that may lead to memory leak.
| (scan_period_t)0 | ||
| ); | ||
| if (ret == BLE_ERROR_NONE) { | ||
| _connection_parameters = new ConnectionParameters(connectionParams); |
|
Thanks, I added an enum and used the extra 3rd state to avoid having an internal connect since the connect is called synchronously from the scan result so I can use that state to know it's an internal call. |
pan-
approved these changes
Oct 1, 2020
| @@ -532,15 +528,26 @@ ble_error_t Gap::connect( | |||
| ble_error_t ret = BLE_ERROR_INTERNAL_STACK_FAILURE; | |||
|
|
|||
| #if BLE_GAP_HOST_BASED_PRIVATE_ADDRESS_RESOLUTION | |||
| /* if host resolution is used we need to connect in two passes, first we scan for addresses to find | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Search for RPA in advertising so we can connect using resolved address.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers
@pan-