Skip to content

Define SD and STORAGE for the MAX32630FTHR and prevent warnings during compilation on Mbed 5.12 and above #13743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 15, 2020
Merged

Define SD and STORAGE for the MAX32630FTHR and prevent warnings during compilation on Mbed 5.12 and above #13743

merged 5 commits into from
Oct 15, 2020

Conversation

idea--list
Copy link
Contributor

@idea--list idea--list commented Oct 8, 2020 •
edited
Loading

MAX32630FTHR has an on-board uSD slot, but targets.json did not contain info about this until now.
Handling it in targets.json is a better idea than doing it via mbed_app.json each time as most people can not figure out how to do that.

Summary of changes

Tells Mbed this target has an SD slot, thus when using SD related APIs it can compile without errors.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@idea--list
Define SD and STORAGE for the MAX32630FTHR
a9dfa0c 
MAX32630FTHR has an on-board uSD slot, but targets.json did not contain info about this until now.
Handling it in targets.json is a better idea than doing it via mbed_app.json as most people can not figure out how to do that.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Oct 8, 2020
@ciarmcom ciarmcom requested a review from a team October 8, 2020 14:30
@ciarmcom
Copy link
Member

ciarmcom commented Oct 8, 2020

@idea--list, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@idea--list
Prevent warnings during compilations for MAX32630FTHR
48c71b3 
In Mbed OS 5.12.0 mbed_toolchain.py has been introduced, that automatically defines the macro TARGET_NAME (on line 241). This leads to a high number of generating the following warning: 'TARGET_NAME' macro redefined while compiling code for MAX32630FTHR on Mbed OS 5.12 and above. This patch fixes it, while it keeps the definition in place for lower versions that lack mbed_toolchain.py
@idea--list
Prevent warnings during compilations for MAX32625
fee7a1c 
In Mbed OS 5.12.0 mbed_toolchain.py has been introduced, that automatically defines the macro TARGET_NAME (on line 241). This leads to a high number of generating the following warning: 'TARGET_NAME' macro redefined while compiling code for MAX32625 on Mbed OS 5.12 and above. This patch fixes it, while it keeps the definition in place for lower versions that lack mbed_toolchain.py
@idea--list
Prevent warnings during compilations for MAX32620C
669c703 
In Mbed OS 5.12.0 mbed_toolchain.py has been introduced, that automatically defines the macro TARGET_NAME (on line 241). This leads to a high number of generating the following warning: 'TARGET_NAME' macro redefined while compiling code for MAX32620C on Mbed OS 5.12 and above. This patch fixes it, while it keeps the definition in place for lower versions that lack mbed_toolchain.py
@idea--list idea--list changed the title Define SD and STORAGE for the MAX32630FTHR Define SD and STORAGE for the MAX32630FTHR and prevent warnings during compilation on Mbed 5.12 and above Oct 8, 2020
0xc0170
0xc0170 previously requested changes Oct 13, 2020
View reviewed changes
targets/targets.json Outdated
"PORTINOUT",
"PORTOUT",
"PWMOUT",
"SD",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the alignment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170
Opened up targets.json in github's file editor. It seemed it was aligned properly to all the other lines.
Copied that line from Mbed Studio, that might have handled indentation different from what github expects.
Now i deleted any tabbing for that line (at some point it jumped several characters at once, so there might have been a special tabbing) and indented that line with plain space characters. Hope it is fine now.

@mergify mergify bot dismissed 0xc0170’s stale review October 13, 2020 08:28

Pull request has been modified.

@idea--list
Copy link
Contributor Author

@0xc0170
I fixed the alignment, but the mergify bot still categorizes it under "needs work".
Can you please check if it is ready to be merged now?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 15, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 2514479 into ARMmbed:master Oct 15, 2020
@mergify mergify bot removed the ready for merge label Oct 15, 2020
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@idea--list @ciarmcom @0xc0170 @mbed-ci @mbedmain