Skip to content

CMake: Use relative paths to list source files and directories #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2020
Merged

CMake: Use relative paths to list source files and directories #13882

merged 1 commit into from
Nov 11, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

The absolute path is still required for listing linker
files as they are referenced from a function in the top
level CMake input source file.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba changed the title CMake: Use relative paths to list source and directories CMake: Use relative paths to list source files and directories Nov 9, 2020
@hugueskamba
CMake: Use relative paths to list source files and directories
794e32d 
The absolute path is still required for listing linker
files as they are referenced from a function in the top
level CMake input source file.
@hugueskamba hugueskamba force-pushed the hk_cmake_use_relative_paths branch from 7bcb729 to 794e32d Compare November 9, 2020 12:33
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 9, 2020
@ciarmcom ciarmcom requested review from pan- and a team November 9, 2020 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Nov 9, 2020

@hugueskamba, thank you for your changes.
@pan- @ARMmbed/mbed-os-core @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-security @ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@0xc0170 0xc0170 removed request for a team and pan- November 9, 2020 13:10
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2020

I also noticed this in our examples today when merging PRs

rajkan01
rajkan01 approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Nov 10, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 10, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 10, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 10, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 mentioned this pull request Nov 11, 2020
Merged
@0xc0170 0xc0170 merged commit 0909f6f into ARMmbed:master Nov 11, 2020
@mergify mergify bot removed the ready for merge label Nov 11, 2020
@hugueskamba hugueskamba deleted the hk_cmake_use_relative_paths branch November 11, 2020 15:26
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@rajkan01 rajkan01 rajkan01 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release-version: 6.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @ciarmcom @0xc0170 @mbed-ci @rajkan01 @mbedmain