Skip to content

Workaround to fix RTC-reset issue on the EFM32GG11_STK3701 #13907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2020
Merged

Workaround to fix RTC-reset issue on the EFM32GG11_STK3701 #13907

merged 3 commits into from
Dec 9, 2020

Conversation

petroborys
Copy link
Contributor

Summary of changes

Workaround to fix RTC-reset issue on the EFM32GG11_STK3701.

Fix #13790

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 13, 2020
@ciarmcom ciarmcom requested review from a team November 13, 2020 13:00
@ciarmcom
Copy link
Member

@petroborys, thank you for your changes.
@ARMmbed/team-silabs @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix

targets/TARGET_Silicon_Labs/TARGET_EFM32/rtcc.c Outdated
RTCC->RET[0].REG = 0;

//Update time
if (RTCC->RET[1].REG == 0) rtc_write(t);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you follow the style in the file, for instance for if:

    if (flags & RTCC_IF_CC0) {
        lp_ticker_irq_handler();
    }

@mergify mergify bot added needs: CI and removed needs: review labels Nov 30, 2020
0xc0170
0xc0170 previously requested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request, use 4 spaces for consistency . Otherwise LGTM

@mergify mergify bot added needs: work and removed needs: CI labels Nov 30, 2020
@mergify mergify bot dismissed 0xc0170’s stale review November 30, 2020 16:54

Pull request has been modified.

@petroborys
Copy link
Contributor Author

One small change request, use 4 spaces for consistency . Otherwise LGTM

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2020

@stevew817 you reviewed the bug report, would you review this PR?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 9, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 3a71f31 into ARMmbed:master Dec 9, 2020
@mergify mergify bot removed the ready for merge label Dec 9, 2020
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 6.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTC-reset bug on the EFM32GG11_STK3701 boards rev. b06 and b07
5 participants
@petroborys @ciarmcom @0xc0170 @mbed-ci @mbedmain