ble: Fix persistence in SecurityDB #13942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@paul-szczepanek-arm, thank you for your changes. |
pan-
approved these changes
Nov 25, 2020
| flags->connected = true; | ||
|
|
||
| /* update peer address */ | ||
| SecurityDistributionFlags_t* old_flags = get_distribution_flags(*db_handle); |
There was a problem hiding this comment.
Does it matter to update the peer address ?
There was a problem hiding this comment.
yes, address changed, otherwise we would've found it by address
0xc0170
approved these changes
Nov 25, 2020
|
CI started |
0xc0170
changed the title
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.6.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
There is a set of bugs that interfere with BLE bonding persistence.
The connected flag was is not being updated when entry are found. This sets the flag at appropriate places.
It also updates the peer address if the entry found based on EDIV and Rand does not match the peer address.
The KVStore Security db implementation initialises indices in the array of entries incorrectly. This removes the index altogether and uses the memory address to get the index instead.
Impact of changes
Migration actions required
Documentation
none
Pull request type
Test results
Reviewers