-
Notifications
You must be signed in to change notification settings - Fork 3k
STM: fix ARMClang sct files, using proper -E command #13962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is required for ARMClang, otherwise there is an error with unknown command.
@0xc0170, thank you for your changes. |
...M/TARGET_STM32H7/TARGET_STM32H745xI/TARGET_STM32H745xI_CM4/TOOLCHAIN_ARM/stm32h745xI_CM4.sct
Outdated
Show resolved
Hide resolved
...M/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_STM32H747xI_CM4/TOOLCHAIN_ARM/stm32h747xI_CM4.sct
Outdated
Show resolved
Hide resolved
Fixed both as requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Back to this PR... |
armclang linker needs it to execute preprocessor, explained in the ARMClang documentation . I can't find the exact link but quickly found:
If you do not have this first line, linker would not invoke anything else. |
Summary of changes
This is required for ARMClang, otherwise there is an error with unknown command. I forgot to fix this in the previous PR where I added CMake files.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers