Skip to content

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 25, 2020

Summary of changes

This is required for ARMClang, otherwise there is an error with unknown command. I forgot to fix this in the previous PR where I added CMake files.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


This is required for ARMClang, otherwise there is an error with unknown command.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 25, 2020
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team November 25, 2020 14:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 25, 2020

Fixed both as requested

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 26, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Nov 26, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit d0cfc67 into ARMmbed:master Nov 26, 2020
@0xc0170 0xc0170 deleted the cmake-fix-stm-armclang branch November 26, 2020 13:13
@mergify mergify bot removed the ready for merge label Nov 26, 2020
@jeromecoutant
Copy link
Collaborator

Back to this PR...
Could you explain why this line has to be added ?
It is a duplication with files in https://github.com/ARMmbed/mbed-os/tree/master/tools/cmake/cores ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Dec 3, 2020

armclang linker needs it to execute preprocessor, explained in the ARMClang documentation . I can't find the exact link but quickly found:

Use the first line in the scatter file to specify a preprocessor command that the linker invokes to process the file.

If you do not have this first line, linker would not invoke anything else.

@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants