Add proper power save mode command format for MTS_DRAGONFLY_L471

[felser]

Summary of changes

Add +CPSMS command formatted properly for the ublox radio used on the MTS_DRAGONFLY_L471QG.
The default +CPSMS format does not work for this radio.

Impact of changes

Migration actions required

Documentation

None

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Tested values for the periodic and active timers in each granularity range on the MTS_DRAGONFLY_L471QG.

---

Reviewers

---

[ciarmcom]

@felser, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

I realized this is in generic AT file, adding TARGET_ exception. Isn't there a better way to do this?

@ARMmbed/mbed-os-connectivity Please review

[trowbridgec]

The set_power_save_mode() function is marked as virtual for AT_CellularDevice:

    virtual nsapi_error_t set_power_save_mode(int periodic_time, int active_time = 0);

Based on that, it might be best to override the function in the inheriting class instead of making the change universally in the base class.

[felser]

I can certainly override the function instead. Should I do a fresh PR?

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

[0xc0170]

I can certainly override the function instead. Should I do a fresh PR?

@felser or update this PR with description.

Pull request has been modified.

[felser]

I updated this pull request. Now it overrides the set_power_save_mode(...) function in the derived SARA4_PPP class.

[pan-]

Thanks @felser. Could you provide the tests results associated with this change ?

[felser]

Test results updated.

[0xc0170]

CI started

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️

[adbridge]

@pan- could you please confirm if you are ok with this now ?
Then we will need to re-run CI as it was last run 20 days ago.