-
Notifications
You must be signed in to change notification settings - Fork 3k
ble cyw43xxx: dev/hci driver terminate #14009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
0xc0170
merged 8 commits into
ARMmbed:master
from
keithmwheeler:pr-dev/hci-driver-terminate
Dec 10, 2020
Merged
ble cyw43xxx: dev/hci driver terminate #14009
0xc0170
merged 8 commits into
ARMmbed:master
from
keithmwheeler:pr-dev/hci-driver-terminate
Dec 10, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es interrupts and GPIO
… to reset BT device via regulator control; modifications to terminate method
… order of BT POWER in declarations
…nd cy_bt_cordio_cfg; removing freeing of dev wake pin and changing to deasserting this during terminate
Kmwh swint 2 See merge request repo/mbed-os!702
0xc0170
approved these changes
Dec 9, 2020
I set this to patch update (target update only). |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Is this ready for integration? It was reopened without any heads up. Just want to make sure this is ready after closure/reopening. |
@keithmwheeler Please let us know, we can merge this asap |
@0xc0170 yes this is ready; the previous open/close was inadvertent. Thank you! |
This was referenced Dec 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Added code to HCI terminate method to release UART and power down external BT device.
Changed HCI init to pass in BT power pin, removed unnecessary delay in init. Added code to insure external BT device is power cycled for reset.
Impact of changes
Migration actions required
Documentation
NA
Pull request type
Test results
Tested via greentea. No additional issues were noted when compared to master. Results attached.
Reviewers
@ARMMbed/team-cypress
GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43438EVB_01_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt