Skip to content

ble cyw43xxx: dev/hci driver terminate #14009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 10, 2020

Conversation

keithmwheeler
Copy link
Contributor

@keithmwheeler keithmwheeler commented Dec 7, 2020

Summary of changes

Added code to HCI terminate method to release UART and power down external BT device.

Changed HCI init to pass in BT power pin, removed unnecessary delay in init. Added code to insure external BT device is power cycled for reset.

Impact of changes

Migration actions required

Documentation

NA


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Tested via greentea. No additional issues were noted when compared to master. Results attached.


Reviewers

@ARMMbed/team-cypress


GT_FT_KIT_062_BLE_GCC.txt
GT_FT_KIT_062_WIFI_BT_GCC.txt
GT_FT_KIT_062S2_43012_GCC.txt
GT_FT_P6S1_43012EVB_01_GCC.txt
GT_FT_P6S1_43438EVB_01_GCC.txt
GT_FT_PROTO_062_4343W_GCC.txt

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Dec 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

I set this to patch update (target update only).

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 9, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 changed the title Pr dev/hci driver terminate ble cyw43xxx: dev/hci driver terminate Dec 9, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 9, 2020

Is this ready for integration? It was reopened without any heads up. Just want to make sure this is ready after closure/reopening.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

@keithmwheeler Please let us know, we can merge this asap

@keithmwheeler
Copy link
Contributor Author

@0xc0170 yes this is ready; the previous open/close was inadvertent. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants