Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Add support for CORDIO Greentea tests #14099

Merged
merged 1 commit into from
Jan 20, 2021
Merged

CMake: Add support for CORDIO Greentea tests #14099

merged 1 commit into from
Jan 20, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 29, 2020 •
edited
Loading

Summary of changes

The Cordio Greentea tests can now be built with CMake.

Preceding PR #14072

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mergify mergify bot added the needs: work label Dec 29, 2020
rajkan01
rajkan01 approved these changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xc0170
0xc0170 previously approved these changes Jan 5, 2021
View reviewed changes
@adbridge adbridge added the release-type: patch Indentifies a PR as containing just a patch label Jan 6, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

Please rebase as well, it will go into CI

@hugueskamba
CMake: Add support for CORDIO Greentea tests
51bd84e 
The Cordio Greentea tests can now be built with CMake.
@hugueskamba
Copy link
Collaborator Author

Please rebase as well, it will go into CI

Done.

@mergify mergify bot dismissed 0xc0170’s stale review January 11, 2021 16:31

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

CI started

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Jan 18, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 18, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

License, restarting CI

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@mergify mergify bot added needs: work and removed needs: CI labels Jan 18, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

Again the license issue, I'll restart

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ❌

@mergify mergify bot added needs: work and removed needs: CI labels Jan 19, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

I found this in the logs: Fatal error: L3903U: Argument 'Cortex-M3' not permitted for option 'cpu' for * FVP_MPS2_M3::ARMC6::HAL-TESTS-TESTS-MBED_HAL-MINIMUM_REQUIREMENTS. I could not find failures for other targets but they were reported as "fail".

Although again license error but I dont think this is license issue. The failures are real,please investigate the build logds.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

Looking at the PR, id does not touch anything in the old tools (build example should work). This is weird..

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

Internal error, we will restart CI once it's ready.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌
jenkins-ci/mbed-os-ci_greentea-test ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 20, 2021

Restarted again

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 8 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 83c18dd into ARMmbed:master Jan 20, 2021
@mergify mergify bot removed the ready for merge label Jan 20, 2021
@hugueskamba hugueskamba deleted the hk_cmake_greentea_cordio branch January 21, 2021 09:00
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@rajkan01 rajkan01 rajkan01 approved these changes

@pan- pan- Awaiting requested review from pan-

@paul-szczepanek-arm paul-szczepanek-arm Awaiting requested review from paul-szczepanek-arm

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hugueskamba @0xc0170 @mbed-ci @rajkan01 @adbridge @mbedmain