Fix minimal-printf floating point decimal output error #14179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caoddx, thank you for your changes. |
0xc0170
approved these changes
Jan 22, 2021
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
evedon
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
This line was indeed missing from the final review of the PR, as we can see here https://github.com/ARMmbed/mbed-os/pull/13548/files#r537611861
Thanks for the fix!
0xc0170
added
release-type: patch
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.8.0
Release-pending
and removed
release-type: patch
LarsTimm
added a commit
to AudioStreamingPlatform/mbed-os
that referenced
this pull request
Mar 17, 2021
Backported ARMmbed#14179 to fix printing floats. 3.3 would be printed as 3.03, as would 3.4 as the integer value was printed after the decimal point also. Even with this fix there where another corner case. 0.9976 would be printed as 0.100 as 99 was rounded up without overflowing to the integer value. With this change 0.9976 is printed as 0.99 (Overflow to integer quite complex...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix #14069
Need this configuration file for testing:
platform/tests/TESTS/mbed_platform/minimal-printf/compliance/test_config.jsonDocumentation
none
Pull request type
Test results
Reviewers