-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32WL : add LoRa support #14249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32WL : add LoRa support #14249
Conversation
0bc3810
to
699edff
Compare
@jeromecoutant, thank you for your changes. |
@jeromecoutant, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a simple request, otherwise LGTM
#ifndef MBED_LORA_RADIO_DRV_STM32WL_LORARADIO_H_ | ||
#define MBED_LORA_RADIO_DRV_STM32WL_LORARADIO_H_ | ||
|
||
#include "mbed_critical.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should also this be platform/ (some use below component name)
same below for drivers/DigitalOut
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
As you know, the STM32WL System-On-Chip integrates both a general purpose microcontroller and a sub-GHz radio on the same chip.
This pull request is then enabling LoRa support for STM32WL,
and tested with NUCLEO_WL55JC target.
@ARMmbed/team-st-mcd
@ludoch-stm
Impact of changes
Migration actions required
Documentation
Readme files added
Pull request type
Test results
Tests done:
with ARM and GCC
with OS and baremetal
with mbed and mbedtools
[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR
Reviewers