Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLE: Add API to test the presence of an event handler in a chain. #14256

Merged
merged 1 commit into from
Feb 11, 2021
Merged

BLE: Add API to test the presence of an event handler in a chain. #14256

merged 1 commit into from
Feb 11, 2021

Conversation

pan-
Copy link
Member

@pan- pan- commented Feb 9, 2021

Summary of changes

Add a function to test if an handler is present in an event chain.

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team February 9, 2021 20:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 9, 2021

@pan-, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 9, 2021 20:00
@mergify mergify bot added needs: CI and removed needs: review labels Feb 10, 2021
@pan- pan- force-pushed the ble-chainable-event-handler-test branch from 38bab18 to 602723d Compare February 10, 2021 11:05
@mergify mergify bot dismissed paul-szczepanek-arm’s stale review February 10, 2021 11:06

Pull request has been modified.

@pan-
Copy link
Member Author

pan- commented Feb 10, 2021

@paul-szczepanek-arm I have updated the PR according to your comments.

@pan- pan- force-pushed the ble-chainable-event-handler-test branch from 602723d to edd7678 Compare February 10, 2021 11:19
AGlass0fMilk
AGlass0fMilk approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@AGlass0fMilk AGlass0fMilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 10, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Feb 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 871522c into ARMmbed:master Feb 11, 2021
@mergify mergify bot removed the ready for merge label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGlass0fMilk AGlass0fMilk AGlass0fMilk approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Assignees
No one assigned
Labels
release-version: 6.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pan- @ciarmcom @0xc0170 @mbed-ci @AGlass0fMilk @paul-szczepanek-arm @mbedmain