BLE: fix termination of periodic advertising sync

[paul-szczepanek-arm]

Summary of changes

This is a fix for Cordio peculiarity where it expects internal sync id instead of the handle to terminate a periodic advertising sync.

There are 3 ids for a sync: SID, handle, sync ID. SID can be used to create the sync, handle is used by the controller to identify the sync, sync ID is an internal cordio host id that identifies the sync control block. The problem is that the terminate sync function doesn't use the controller handle as an argument and instead expects the internal handle.

This is a workaround since now the user is getting the internal sync id instead of the handle - which should be OK since the handle can be considered an opaque ID and should not be used by the user for anything else.

Real solution IMHO would be to create a Cordio terminate function that accepts the handle instead.

Impact of changes

Migration actions required

Documentation

none

---

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@pan-

---

[ciarmcom]

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

CI started

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM	✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM	✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-example-ARM	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cmake-example-test	✔️