CMake Maxim: fix targets naming #14270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
commented
Feb 11, 2021
| TARGET_MAX32630FTHR | ||
| ) | ||
|
|
||
| target_sources(mbed-core |
There was a problem hiding this comment.
this needs fixing, on it, somehow the target was left out
Add boot no-boot targets for max32625. This should be cleaned up better once we get the folder structure enforced by the old tools fixed.
0xc0170
force-pushed
the
cmake-refactor-maxim
branch
from
ccdb5d9
to
351d674
Compare
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
|
I built couple of targets, added few fixes. I'll continue testing tomorrow morning (one more ld error oustanding). |
Forgotten to set it for the target
|
CI started to get early results |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
ahmetalincak
approved these changes
Feb 13, 2021
hugueskamba
previously requested changes
Feb 14, 2021
targets/TARGET_Maxim/TARGET_MAX32625/TARGET_MAX32625MBED/CMakeLists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_Maxim/TARGET_MAX32625/TARGET_MAX32625MBED/CMakeLists.txt
Outdated
Show resolved
Hide resolved
targets/TARGET_Maxim/TARGET_MAX32625/TARGET_MAX32625MBED/CMakeLists.txt
Outdated
Show resolved
Hide resolved
Co-authored-by: Hugues Kamba-Mpiana <41612201+hugueskamba@users.noreply.github.com>
mergify
bot
dismissed
hugueskamba’s stale review
Pull request has been modified.
|
I fixed MAX32630FTHR CMake, builds OK locally |
hugueskamba
approved these changes
Feb 15, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.8.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add boot no-boot targets for max32625. This should be cleaned up better once we get
the folder structure enforced by the old tools fixed.
Summary of changes
Set the CMake naming for Maxim targets.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers